-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix services tty output #557
Conversation
Itxaka
commented
Dec 4, 2023
- interactive installer: output was not connected to tty so it was impossible to answer any questions
- reset: was not getting the output and taking over the tty so it got overwritten by other output. It could be stopped in the middle
- installer: same as above but it could lead to stopping the install in the middle of it
- recovery: same as above, QR code didnt even display
- interactive installer: output was not connected to tty so it was impossible to answer any questions - reset: was not getting the output and taking over the tty so it got overwritten by other output. It could be stopped in the middle - installer: same as above but it could lead to stopping the install in the middle of it - recovery: same as above, QR code didnt even display Signed-off-by: Itxaka <[email protected]>
packages/static/kairos-overlay-files/files/etc/systemd/system/kairos-interactive.service
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…kairos-interactive.service
If there something doesn't work, we should at least understand why it doesn't work before changing it back. |
I don't get why it doesn't work, probably systemd is mangling the output somehow but it doesn't work as expected. You can try yourself by testing master with interactive install or recovery and see how it breaks the tty1 output. With this, which was the original setting from a long time ago, it doesn't. But to make it work and not keep it broken we need to reverse this to a working state and then change it back to jornal+console as currently is a regression. I wonder if the way we interact by Kairos agent is the reason, maybe we need to do changes there. |
I'm fine to revert it for now to fix the regression. Let's open a new issue to investigate further and bring the change back properly. |
umm, for the interactive installer at least, this is necessary to set the tty otherwise we got no control over the input/output with our current implementation. maybe we could workaround the others somehow? |