Demo app fixes #182
Merged
Demo app fixes #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robinst
commented
Aug 24, 2022
robinst
commented
- Fix swipe action (second file wasn't included in project)
- Fix showing label about GIF info
- Include third test GIF in demo as well (why not?)
- Fix swipe action (second file wasn't included in project) - Fix showing label about GIF info - Include third test GIF in demo as well (why not?)
robinst
commented
Aug 24, 2022
| @@ -40,7 +39,7 @@ class ViewController: UIViewController { | |||
| } | |||
|
|
|||
| func animate() { | |||
| imageView.animate(withGIFNamed: currentGIFName, animationBlock: { | |||
| imageView.animate(withGIFNamed: currentGIFName, preparationBlock: { | |||
There was a problem hiding this comment.
animationBlock is never run because the GIF loops indefinitely. animationBlock is only called once the whole animation has finished. With preparationBlock it works as intended.
| currentGIFName = "earth" | ||
| default: | ||
| currentGIFName = "mugen" | ||
| let gifs = ["mugen", "earth", "nailed"] |
There was a problem hiding this comment.
Cycle through all three GIFs (why not).
| @@ -149,7 +153,9 @@ | |||
| 9D98823A19BC69CA00B790C6 /* Supporting Files */ = { | |||
| isa = PBXGroup; | |||
| children = ( | |||
| A5D726E728B53C0800821347 /* earth.gif */, | |||
There was a problem hiding this comment.
Hard to review this change but before, only the mugen.gif was included in the files so swiping in the demo app didn't work.
There was a problem hiding this comment.
I was only trying the first one in my manual regression tests so never noticed. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.