Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields Head and Tail of proto/varlogpb.(LogStreamDescriptor) are deprecated. #73

Closed
ijsong opened this issue Aug 25, 2022 · 0 comments · Fixed by #261 or #259
Closed

Fields Head and Tail of proto/varlogpb.(LogStreamDescriptor) are deprecated. #73

ijsong opened this issue Aug 25, 2022 · 0 comments · Fixed by #261 or #259
Assignees
@ijsong

Comments

@ijsong
Copy link
Member

ijsong commented Aug 25, 2022

Two fields are deprecated soon:

  • proto/varlogpb.(LogStreamDescriptor).Head
  • proto/varlogpb.(LogStreamDescriptor).Tail

A LogStreamDescriptor represents attributes of a log stream that are immutable or changed hardly, but the head and tail of the log location are subject to change. So we no longer use them.
ijsong added a commit that referenced this issue Aug 25, 2022
@ijsong
style: resolve lint warnings - staticcheck
b4d1f32 
It skips lint warnings related to #73, #74, and #75.
@ijsong ijsong mentioned this issue Aug 25, 2022
Merged
ijsong referenced this issue in ijsong/varlog Sep 12, 2022
@ijsong
refactor(storagenode): add LogStreamReplicaMetadata to `/varlog.snp…
1ce7ec6 
…b.LogIO` to replace `LogStreamMetadata`

Refs: #73
@ijsong ijsong mentioned this issue Sep 12, 2022
Merged
@ijsong ijsong mentioned this issue Dec 9, 2022
Merged
ijsong referenced this issue in ijsong/varlog Dec 9, 2022
@ijsong
refactor(client,storagenode): remove Head and Tail from proto/varlogp…
a8caa18 
…b.(LogStreamDescriptor)

This patch removes deprecated fields - `proto/varlogpb.(LogStreamDescriptor).Head` and
`proto/varlogpb.(LogStreamDescriptor).Tail`. It also removes deprecated APIs -
`pkg/varlog.(Log).LogStreamMetadata` and `pkg/varlog.(Log).LogStreamReplicaMetadata`.

Resolves #73
@ijsong ijsong self-assigned this Dec 9, 2022
ijsong referenced this issue in ijsong/varlog Dec 9, 2022
@ijsong
feat(client,storagenode): remove Head and Tail from proto/varlogpb.(L…
57161c8 
…ogStreamDescriptor)

This patch removes deprecated fields - `proto/varlogpb.(LogStreamDescriptor).Head` and
`proto/varlogpb.(LogStreamDescriptor).Tail`. It also removes deprecated APIs -
`pkg/varlog.(Log).LogStreamMetadata` and `pkg/varlog.(Log).LogStreamReplicaMetadata`.

Resolves #73
@ijsong ijsong mentioned this issue Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ijsong ijsong

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ijsong