FEC-10389 Add support for referenceId filter in provider (#23) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MediaEntry Interceptors business logic for KalturaPlayer and KalturaOTTPlayer. * code fixes * - PKMediaEntryInterceptor protocol definition moved to Sources/Basic/Interceptor/ - KalturaPlayer.swift internal getter for interceptors changed to use generic getLoadedPlugins function. - Podspec modified to include PKMediaEntryInterceptor in "Core" subspec, also added "Interceptor" subspec to include only PKMediaEntryInterceptor for other development needs. * Update KalturaPlayer.swift Minor code style fixes. * Update KalturaPlayer.podspec renamed to playkitVersion * Update KalturaPlayer.podspec Co-authored-by: Noam Tamim <[email protected]> * Update KalturaPlayer.podspec Co-authored-by: Noam Tamim <[email protected]> * Update Sources/Basic/Interceptor/PKMediaEntryInterceptor.swift Co-authored-by: Nilit Danan <[email protected]> * interceptor.apply minor code style fixes * Interceptor related code moved to extension of KalturaPlayer class. * Interceptor podspec fixes * Removed parameter callback from internal func updateMediaEntryWithLoadedInterceptors(_ mediaEntry: PKMediaEntry) * podspec updated * PKMediaEntryInterceptor protocol changed * Update Sources/Interceptor/PKMediaEntryInterceptor.swift Co-authored-by: Nilit Danan <[email protected]> * updateMediaEntryWithLoadedInterceptors() callback added * FEC-10389 Add support for referenceId filter in provider. Changes required for player. Co-authored-by: Noam Tamim <[email protected]> Co-authored-by: Nilit Danan <[email protected]>
x-NR-x
approved these changes
Mar 1, 2021
|
don't merge, we need the version of providers dependency to be updated in the podspec. |
x-NR-x
added a commit
that referenced
this pull request
Mar 1, 2021
x-NR-x
added a commit
that referenced
this pull request
Mar 1, 2021
* develop: Fixed Travis script, wasn't complete. Added missing pod declarations in the iOSTestApp. Added missing tvOSTestApp. Added to the travis build script to check the tvOSTestApp as well. Revert "FEC-10389 Add support for referenceId filter in provider (#23) (#26)" (#27) FEC-10389 Add support for referenceId filter in provider (#23) (#26) FEC-10688 Added a function to bypass the config fetching, in case the environment is not ready. (#25) FEC-10751 Updated travis to use Xcode 12 image and added Oren M and Sergey C to the recipients. (#24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEC-10389 Add support for referenceId filter in provider (#23)