Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEC-11857 PhoenixMediaProvider networkProtocol changed to be required… #45

Merged
merged 2 commits into from
Jan 25, 2022
Merged

FEC-11857 PhoenixMediaProvider networkProtocol changed to be required… #45

merged 2 commits into from
Jan 25, 2022

Conversation

chausov
Copy link
Contributor

@chausov chausov commented Jan 11, 2022

Solves FEC-11857
PhoenixMediaProvider networkProtocol changed to be required https

@chausov chausov requested a review from x-NR-x January 17, 2022 09:13
x-NR-x
x-NR-x reviewed Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@x-NR-x x-NR-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chausov don't you think it will be best to have the default here as well? So whoever uses KP will know there is a default value.

@chausov
Copy link
Contributor Author

chausov commented Jan 20, 2022

@chausov don't you think it will be best to have the default here as well? So whoever uses KP will know there is a default value.

ok, will do

@chausov chausov requested a review from x-NR-x January 21, 2022 14:06
@chausov chausov merged commit 13e2a6b into develop Jan 25, 2022
@chausov chausov deleted the FEC-11857 branch January 25, 2022 11:19
x-NR-x added a commit that referenced this pull request Jan 26, 2022
@x-NR-x
Merge branch 'develop' into FEC-11914
a3bf0a6 
* develop:
  FEC-11857 PhoenixMediaProvider networkProtocol changed to be required… (#45)
x-NR-x added a commit that referenced this pull request Feb 10, 2022
@x-NR-x
Merge branch 'develop' into FEC-11867
bfec2c5 
* develop:
  FEC-10249 Updating the code to update the player options ks in the KalturaPlayer class, the Base class, and not in OVP and OTT.
  FEC-11834 Fix for Xcode 12 (ambiguous error)
  FEC-11834 SkipAd button conflict with other UI layers fixed. (#52)
  FEC-11830 Start time fixes for Playlist OTT/OVP medias. (#51)
  FEC-11766 Postroll playback fixes for playlist (#48)
  FEC-11934 Calling stop on the player if it is destroyed. (#53)
  FEC-11914 Bookmarks are not sent when the ks is set on the media options alone. (#49)
  FEC-11683 OTT - Setting the fix of the serverURL in the setter so that it will be fixed for all requests. (#50)
  FEC-11857 PhoenixMediaProvider networkProtocol changed to be required… (#45)
  FEC-11737 PhoenixAnalyticsPlugin fixes for default plugin and plugin override. (#46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-NR-x x-NR-x x-NR-x approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chausov @x-NR-x