Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7907, FEC-7872): No play button when preload and ima plugin #91

Merged
merged 6 commits into from
Feb 19, 2018
Merged

fix(FEC-7907, FEC-7872): No play button when preload and ima plugin #91

merged 6 commits into from
Feb 19, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Feb 14, 2018 •
edited
Loading

Description of the Changes

raise a flag once loadMedia is invoked. see kaltura/playkit-js#193

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Feb 14, 2018
@yairans yairans requested a review from dan-ziv February 14, 2018 08:59
@yairans yairans changed the title fix(FEC-7907): No play button when preload and ima plugin fix(FEC-7907, FEC-7872): No play button when preload and ima plugin Feb 14, 2018
@yairans yairans mentioned this pull request Feb 14, 2018
Merged
5 tasks
@dan-ziv dan-ziv requested a review from OrenMe February 14, 2018 13:41
@dan-ziv dan-ziv merged commit 58b0dec into master Feb 19, 2018
@dan-ziv dan-ziv deleted the FEC-7907 branch February 19, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @dan-ziv