Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7907, FEC-7872): No play button when preload and ima plugin #193

Merged
merged 14 commits into from
Feb 19, 2018
Merged

fix(FEC-7907, FEC-7872): No play button when preload and ima plugin #193

merged 14 commits into from
Feb 19, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Feb 14, 2018 •
edited
Loading

Description of the Changes

in this change we consider in first play several options:

  • there is source to play => play
  • there is no source but will be soon (response delayed) => wait for source
  • no source at all => throw error

this change removes a complicated logic from the UI project see kaltura/playkit-js-ui#173
and depends on a minor change in kaltura-player see kaltura/kaltura-player-js#91

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Feb 14, 2018
@yairans yairans requested a review from dan-ziv February 14, 2018 09:06
@yairans yairans changed the title fix(FEC-7907): No play button when preload and ima plugin fix(FEC-7907, FEC-7872): No play button when preload and ima plugin Feb 14, 2018
This was referenced Feb 14, 2018
Merged
Merged
@dan-ziv dan-ziv requested a review from OrenMe February 14, 2018 13:40
@dan-ziv dan-ziv merged commit 2975fdc into master Feb 19, 2018
@dan-ziv dan-ziv deleted the FEC-7907 branch February 19, 2018 13:51
dan-ziv pushed a commit to kaltura/playkit-js-ui that referenced this pull request Feb 19, 2018
@yairans
fix(FEC-7907): No play button when preload=auto and ima plugin enabled (
20e98f6 
#173)

show pre playback play button as soon as possible and load spinner once clicked
this change is possible since kaltura/playkit-js#193
dan-ziv pushed a commit to kaltura/kaltura-player-js that referenced this pull request Feb 19, 2018
@yairans
fix(FEC-7907, FEC-7872): No play button when preload=auto and ima plu…
58b0dec 
…gin enabled (#91)

raise a flag once loadMedia is invoked. see kaltura/playkit-js#193
@yairans yairans mentioned this pull request Feb 21, 2018
Merged
5 tasks
yairans added a commit that referenced this pull request Feb 25, 2018
@yairans
fix(FEC-7872): Player stuck in case of multirequest is not fully load…
9537d42 
…ed (#197)

* Solution for Android Chrome which requires user gesture on the specific video element (part of #193)
* Do not wait to sourceselected event before ad playing, play ad immediately, see kaltura/playkit-js-ima#45
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
fix(FEC-7907): No play button when preload=auto and ima plugin enable…
b3575b4 
…d (#173)

show pre playback play button as soon as possible and load spinner once clicked
this change is possible since kaltura/playkit-js#193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yairans @OrenMe @dan-ziv