feat(FEC-11761): expose stream timed metadata - phase 2 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semarche-kaltura
requested changes
Jan 10, 2022
ts-typed/cue-point-manager.d.ts
Outdated
| export interface CuePointManager { | ||
| getAllCuePoints(): Array<VTTCue>; | ||
| getAllCuePoints(): Array<CuePoint>; | ||
| getActiveCuePoints(): Array<VTTCue>; |
There was a problem hiding this comment.
getActiveCuePoints returns Array<CuePoint>
semarche-kaltura
previously approved these changes
Jan 10, 2022
RoyBregman
reviewed
Jan 10, 2022
| @@ -25,25 +19,27 @@ export class CuePointManager { | |||
| } | |||
|
|
|||
| _createTextTrackCue(data: CuePoint): TextTrackCue { | |||
There was a problem hiding this comment.
why are we not using the "private" indication here when methods are internal?
There was a problem hiding this comment.
what is "private" indication?
This was referenced Jan 11, 2022
yairans
added a commit
to kaltura/playkit-js-dual-screen
that referenced
this pull request
Jan 12, 2022
use `CuePoint` from `TIMED_METADATA_CHANGE` instead of `VttCue` from `TIMED_METADATA` Depends on kaltura/kaltura-player-js#512
yairans
added a commit
to kaltura/playkit-js-dual-screen
that referenced
this pull request
Jan 12, 2022
use `CuePoint` from `TIMED_METADATA_CHANGE` instead of `VttCue` from `TIMED_METADATA` Depends on kaltura/kaltura-player-js#512
yairans
added a commit
to kaltura/playkit-js-kaltura-cuepoints
that referenced
this pull request
Jan 12, 2022
pass `CuePoint` to addCuePoints api Depends on kaltura/kaltura-player-js#512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
use
TimedMetadatafrom coreChange cuePointManager API's to use
TimedMetadatainstead ofVttCueSolves FEC-11761
Depends on kaltura/playkit-js#623
Breaking Change for -
kaltura/playkit-js-dual-screen#52
kaltura/playkit-js-kaltura-cuepoints#15
CheckLists