Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12615): add configuration to toggle emsg listener #212

Merged
merged 3 commits into from
Oct 6, 2022
Merged

fix(FEC-12615): add configuration to toggle emsg listener #212

merged 3 commits into from
Oct 6, 2022

Conversation

SivanA-Kaltura
Copy link
Collaborator

@SivanA-Kaltura SivanA-Kaltura commented Oct 3, 2022 •
edited
Loading

Description of the Changes

emsg metadata cues can take up a lot of memory because they contain binary data
this configuration allows toggling the emsg listener off if needed

resolves FEC-12615

related PR: kaltura/playkit-js#668

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura mentioned this pull request Oct 3, 2022
Merged
5 tasks
@SivanA-Kaltura SivanA-Kaltura merged commit 99894f3 into master Oct 6, 2022
@SivanA-Kaltura SivanA-Kaltura deleted the add-emsg-listener-config branch October 6, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladna giladna giladna approved these changes

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SivanA-Kaltura @giladna