Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-7330): Enable setting custom track labels by app #57

Merged
merged 7 commits into from
Apr 10, 2018

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Apr 9, 2018

Description of the Changes

removing the label as we override it in videoTrack.js

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Apr 9, 2018
OrenMe
OrenMe previously approved these changes Apr 9, 2018
@odedhutzler
Copy link
Contributor Author

tests fails because of the new playkit is not updated yet. it will be fixed after.

@odedhutzler odedhutzler merged commit edd0c79 into master Apr 10, 2018
@odedhutzler odedhutzler deleted the FEC-7330 branch April 10, 2018 12:33
dan-ziv pushed a commit that referenced this pull request Jul 16, 2020
Add prettier settings for code style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants