Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove default exports #70

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: remove default exports #70

wants to merge 3 commits into from

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Aug 13, 2018

Description of the Changes

As our project conventions, we decided to remove default exports and use only named exports.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

odedhutzler
odedhutzler previously approved these changes Aug 13, 2018
View reviewed changes
dan-ziv pushed a commit that referenced this pull request Jul 16, 2020
@yairans
feat(FEC-8700): add config option to specify DRM system (#70)
5a7e528 
Consider `drm.keySystem` config which specify the drm system to run with. 
Depends on kaltura/playkit-js#330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odedhutzler odedhutzler odedhutzler left review comments

@OrenMe OrenMe Awaiting requested review from OrenMe

@yairans yairans Awaiting requested review from yairans

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @odedhutzler