Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7234): pause playback on overlay ad clicked #19

Merged
merged 6 commits into from
Oct 3, 2017
Merged

fix(FEC-7234): pause playback on overlay ad clicked #19

merged 6 commits into from
Oct 3, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Oct 3, 2017 •
edited
Loading

Description of the Changes

If an overlay ad is playing and user clicked on it, pause video.
If the video is already paused and user clicked on it, play video.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Oct 3, 2017
@dan-ziv dan-ziv requested a review from OrenMe October 3, 2017 11:29
@OrenMe
Copy link
Contributor

OrenMe commented Oct 3, 2017

Please add description

@dan-ziv
Copy link
Contributor Author

dan-ziv commented Oct 3, 2017

@OrenMe description added.
Please review.

OrenMe
OrenMe previously approved these changes Oct 3, 2017
View reviewed changes
@dan-ziv dan-ziv changed the title fix(FEC-7234): toggle playback on overlay ad click fix(FEC-7234): pause playback on overlay ad click Oct 3, 2017
@dan-ziv dan-ziv changed the title fix(FEC-7234): pause playback on overlay ad click fix(FEC-7234): pause playback on overlay ad clicked Oct 3, 2017
@dan-ziv dan-ziv merged commit 0def2ab into master Oct 3, 2017
@dan-ziv dan-ziv deleted the FEC-7234 branch October 3, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe