fix(ADA-1335): Accessibility- “Close” button within the info video panel. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tzipi-kaltura
requested review from
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
semarche-kaltura
approved these changes
Jul 8, 2024
Tzipi-kaltura
added a commit
to kaltura/playkit-js-ui
that referenced
this pull request
Jul 8, 2024
…nel. (#900) Adding boolean var to check if push to the beginning or to the end. part of - kaltura/playkit-js-info#101 Resolves ADA-1335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When adding a elements in the entry description it's added as a link in info plugin but it is not accessible when pressing on tab, the focus always stay on the close button.
Solution:
Adding the links elements to the accessible child element in the popup-keyboard-accessibility.
Since this is added after the x button need to push it to the beginning of the list (otherwise the focus continue to stay on x button)
Change also done in ui repo - #900 checking if we want to push to the beginning or to the end
ADA-1335