Skip to content

Commit

Permalink
feat(FEC-11608): Provider - Expose default service Url (#14)
Browse files Browse the repository at this point in the history
get the service Url from Kaltura player (which get it from provider)

solves FEC-11608
  • Loading branch information
JonathanTGold committed Nov 29, 2021
1 parent 55453f1 commit 737d625
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/providers/live/live-provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export class LiveProvider extends Provider {
const newThumbCue = {
...newThumb,
...this._makeCuePointStartEndTime(newThumb.createdAt),
assetUrl: makeAssetUrl(this._player.config.provider.env?.serviceUrl, newThumb.assetId, this._player.config.session?.ks)
assetUrl: makeAssetUrl(this._player.provider.env.serviceUrl, newThumb.assetId, this._player.config.session?.ks)
};
this._thumbCuePoints.push(newThumbCue);
this._thumbCuePoints = this._fixCuePointEndTime(this._thumbCuePoints);
Expand Down
4 changes: 1 addition & 3 deletions src/providers/utils.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
export const DEFAULT_SERVICE_URL = '//cdnapisec.kaltura.com/api_v3';

export function isEmptyObject(obj: Record<string, any>) {
return Object.keys(obj).length === 0 && obj.constructor === Object;
}
Expand All @@ -8,6 +6,6 @@ export function getDomainFromUrl(url: string) {
return url.replace(/^(.*\/\/[^\/?#]*).*$/, '$1');
}

export function makeAssetUrl(serviceUrl: string = DEFAULT_SERVICE_URL, assetId: string, ks: string = '') {
export function makeAssetUrl(serviceUrl: string, assetId: string, ks: string = '') {
return `${serviceUrl}/index.php/service/thumbAsset/action/serve/thumbAssetId/${assetId}/ks/${ks}`;
}
2 changes: 1 addition & 1 deletion src/providers/vod/vod-provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export class VodProvider extends Provider {
const createCuePointList = (thumbCuePoints: Array<KalturaThumbCuePoint>) => {
return thumbCuePoints.map((thumbCuePoint: KalturaThumbCuePoint) => {
return {
assetUrl: makeAssetUrl(this._player.config.provider.env?.serviceUrl, thumbCuePoint.assetId, this._player.config.session.ks),
assetUrl: makeAssetUrl(this._player.provider.env.serviceUrl, thumbCuePoint.assetId, this._player.config.session.ks),
id: thumbCuePoint.id,
cuePointType: thumbCuePoint.cuePointType,
startTime: thumbCuePoint.startTime / 1000,
Expand Down

0 comments on commit 737d625

Please sign in to comment.