Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-7186): support external/universal live entries #29

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Sep 24, 2017

Description of the Changes

Add support for extracting mimetype for sources without flavor ids
Main difference here is that we now always parse the metadata for mimetype if we can, but working on this has surfaced many issues I bet we didn't catch yet.
I won't add this here but need to think on making all object as object literals instead of class with contractor to simplify passing them around and add test for the declared use cases, such as VOD entry, VOD with DRM, Kaltura Live, external/universal live, e.g. which is a lot better then testing partner:entryid tests.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

add support for extracting mimetype for sources without flavor ids
@OrenMe OrenMe merged commit b4f143e into master Sep 25, 2017
@OrenMe OrenMe deleted the FEC-7186 branch September 25, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants