fix(FEC-7186): support external/universal live entries #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for extracting mimetype for sources without flavor ids
yairans
approved these changes
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Add support for extracting mimetype for sources without flavor ids
Main difference here is that we now always parse the metadata for mimetype if we can, but working on this has surfaced many issues I bet we didn't catch yet.
I won't add this here but need to think on making all object as object literals instead of class with contractor to simplify passing them around and add test for the declared use cases, such as VOD entry, VOD with DRM, Kaltura Live, external/universal live, e.g. which is a lot better then testing partner:entryid tests.
CheckLists