fix(FEC-13146): Kava sent the View event 4 times #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanTGold
requested review from
giladna,
lianbenjamin,
ErezKaltura,
SivanA-Kaltura and
shaisivan
giladna
approved these changes
May 24, 2023
giladna
approved these changes
May 24, 2023
giladna
added a commit
that referenced
this pull request
Jun 8, 2023
* master: (40 commits) chore(release): 2.39.4 fix(FEC-13134): add ceratedAt and endedDate to media entry metadata if available (#216) fix(SUP-37445): Identifying tags that include 360 as 360 videos (#212) fix(FEC-13123): replace travis with github actions yarn add exact (#215) chore: trigger build fix: trigger build fix(FEC-13146): Kava sent the View event 4 times - fix POST method (#214) fix(FEC-13146): Kava sent the View event 4 times (#213) chore(release): 2.39.3 fix(FEC-13123): replace travis with github actions (#210) fix(FEC-13123): replace travis with github actions (#209) chore(release): 2.39.2 add gitignore chore(release): 2.39.1 fix(FEC-13123): replace travis with github actions (#208) chore(FEC-13123): replace travis with github actions (#207) chore: update dist fix(FEC-13113): fix and add unit tests in handleRegexAction file (#206) chore(release): 2.39.0 chore: update dist ... # Conflicts: # test/src/k-provider/ott/media-config-data.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
issue: the request-builder retry mechanism
retryConfig.maxAttemptsparm set to 4 by defaultTherefore when it comes into action (for example in offline mode) it sends the same report 4 times in a row
fix: set retryConfig.maxAttempts to - 1 on Analytics-service
solves FEC-13146
CheckLists