Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drm keys #23

Merged
merged 7 commits into from
Aug 24, 2017
Merged

fix: drm keys #23

merged 7 commits into from
Aug 24, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Aug 23, 2017 •
edited
Loading

Description of the Changes

Change drm enums to standard drm keys.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Aug 23, 2017
@dan-ziv dan-ziv requested review from OrenMe and yairans August 23, 2017 07:25
@OrenMe
Copy link
Contributor

OrenMe commented Aug 23, 2017

@dan-ziv please check - test are failing

@dan-ziv
Copy link
Contributor Author

dan-ziv commented Aug 23, 2017

@OrenMe
fixed.

OrenMe
OrenMe previously approved these changes Aug 23, 2017
View reviewed changes
@OrenMe
Copy link
Contributor

OrenMe commented Aug 23, 2017

@dan-ziv travis still fails

OrenMe
OrenMe reviewed Aug 23, 2017
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-ziv travis check still fails

@dan-ziv dan-ziv merged commit 083cbfa into master Aug 24, 2017
@dan-ziv dan-ziv deleted the drm branch August 24, 2017 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe