-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(FEC-13632): Divert the kaltura-player-js types to be imported loc…
…ally and not form node_modules (circular deps) (#841) ### Description of the Changes Remove kaltura-player-js dep **Issue:** kaltura player github `actions faild since it depend on playkit-ui types which in turn depend on kaltura-player... and so on.. and on and on... Jesus Christ... Apparently it used by e2e tests... restored **Fix:** dependency should not depend on dependent.... (this is also a general rule for life...) #### Resolves FEC-FEC-13632 Related Prs: kaltura/kaltura-player-js#690 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
- Loading branch information
1 parent
8ddc9e5
commit 1a5779a
Showing
15 changed files
with
2,908 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
src/types/kaltura-player-js.d.ts | ||
p |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.