Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pre-playback-state): hide loading spinner on preloading #59

Merged
merged 6 commits into from
Sep 26, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Sep 26, 2017

Description of the Changes

If player is preloading media a spinner showing in the background of the pre playback button.
This solution will hides the loading spinner and shows only pre-playback button.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Sep 26, 2017
@dan-ziv dan-ziv changed the title fix(pre-playback-button): hide pre playback button on preloading fix(pre-playback-state): hide loading spinner on preloading Sep 26, 2017
OrenMe
OrenMe previously approved these changes Sep 26, 2017
@dan-ziv dan-ziv merged commit 072cc65 into master Sep 26, 2017
@dan-ziv dan-ziv deleted the hide-pre-playback-on-preloading branch September 26, 2017 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants