Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-13118): pause/play playback using keyboard - A11Y issue #775

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix(FEC-13118): pause/play playback using keyboard - A11Y issue #775

merged 2 commits into from
Aug 2, 2023

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Jul 30, 2023 •
edited
Loading

Description of the Changes

solves FEC-13118

issue: the keyboard event listener is listening only to events within the player container element scope

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold merged commit bbb0031 into master Aug 2, 2023
3 checks passed
@JonathanTGold JonathanTGold self-assigned this Aug 2, 2023
@kaltura kaltura deleted a comment from SivanA-Kaltura Aug 8, 2023
@Tzipi-kaltura Tzipi-kaltura mentioned this pull request Nov 6, 2023
Merged
5 tasks
Tzipi-kaltura added a commit that referenced this pull request Nov 7, 2023
@Tzipi-kaltura
fix(ADA-41): [V7-Acc] remove the tabindex="0" attribute from the vide… (
5771ded 
#813)

issue:
after hitting play, tab should be pressed twice to focused on seek bar. first one as a result of #775 and second on the internal div.

solution:
remove the tabIndex=0 from the internal div

solves ADA-41
@JonathanTGold JonathanTGold mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@lianbenjamin lianbenjamin lianbenjamin approved these changes

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

@inbalvasserman inbalvasserman Awaiting requested review from inbalvasserman

@PlaykitJs-Bot PlaykitJs-Bot Awaiting requested review from PlaykitJs-Bot

Assignees

@JonathanTGold JonathanTGold

Labels
Priority: Medium
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonathanTGold @lianbenjamin @SivanA-Kaltura