fix(FEC-13880): Add css dynamic vars to support light theme #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SivanA-Kaltura
requested changes
May 20, 2024
This was referenced May 20, 2024
SivanA-Kaltura
approved these changes
May 21, 2024
JonathanTGold
added a commit
to kaltura/playkit-js-downloads
that referenced
this pull request
May 21, 2024
### Description of the Changes Add support for Light Theme #### Resolves: FEC-13880 Related Prs: kaltura/playkit-js-ui#884 kaltura/playkit-js-share#44 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
added a commit
to kaltura/playkit-js-share
that referenced
this pull request
May 21, 2024
### Description of the Changes Add support for Light Theme #### Resolves: FEC-13880 Related Prs: kaltura/playkit-js-ui#884 kaltura/playkit-js-downloads#52 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: opacity element of css color of Hex format can not dynamically be changed
Fix: expose the tone ramp global vars as rgb values which can be manipulated dynamically using built-in rgba() css funciton (i.e. :
background-color: rgba(255 255 255, 0.1);)Resolves FEC-13880
Related Prs:
kaltura/playkit-js-share#44
kaltura/playkit-js-downloads#52