-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FEC-14080): Accessibility fix for the top bar and the bottom bar #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SivanA-Kaltura
changed the title
TBD
fix(FEC-14080): Accessibility fix for the top bar and the bottom bar
Aug 25, 2024
SivanA-Kaltura
requested review from
lianbenjamin,
semarche-kaltura and
MosheMaorKaltura
August 25, 2024 10:35
lianbenjamin
requested changes
Aug 26, 2024
semarche-kaltura
requested changes
Aug 26, 2024
lianbenjamin
requested changes
Aug 28, 2024
lianbenjamin
approved these changes
Aug 29, 2024
MosheMaorKaltura
approved these changes
Aug 29, 2024
semarche-kaltura
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
When top and bottom bars are visible, use playkit-video-filter div to show a gradient
Related PRs:
kaltura/playkit-js#790
kaltura/playkit-js-dual-screen#150
Resolves FEC-14080