Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ADA-1610): Update aria label for volume button #932

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

valentinStoicaK
Copy link
Contributor

@valentinStoicaK valentinStoicaK commented Aug 27, 2024

Description of the Changes

  • Removed slider aria-label from volume button;
  • Added aria-description to slider so the user would be informed about slider controls;

Issue:

Fix:

Resolves FEC-[Please add the ticket reference here]

src/components/volume/volume.tsx Outdated Show resolved Hide resolved
@valentinStoicaK valentinStoicaK merged commit 28805a8 into master Sep 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants