Skip to content

Commit

Permalink
fix(FEC-10590): DOM play error on SmartTV on when stall happen on the…
Browse files Browse the repository at this point in the history
… beginning (#552)

Issue: shaka stall detector calling pause and play before first play promise resolved, it cause DOM exception and playback stop after this pause. flow is playback play() -> stall detector pause() play() -> play failed handler pause().
Solution: remove the pause from play failed handler since after play is failed browser handle it.
  • Loading branch information
Yuvalke authored Mar 15, 2021
1 parent 37fc3fc commit 089018c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -1761,7 +1761,6 @@ export default class Player extends FakeEventTarget {
this._eventManager.listen(this._engine, CustomEventType.ABR_MODE_CHANGED, (event: FakeEvent) => this.dispatchEvent(event));
this._eventManager.listen(this._engine, CustomEventType.TIMED_METADATA, (event: FakeEvent) => this.dispatchEvent(event));
this._eventManager.listen(this._engine, CustomEventType.PLAY_FAILED, (event: FakeEvent) => {
this.pause();
this._onPlayFailed(event);
this.dispatchEvent(event);
});
Expand Down

0 comments on commit 089018c

Please sign in to comment.