add none to ScreenOrientationType

kaltura · Nov 24, 2020 · 43627ea · 43627ea
1 parent cfc4507
commit 43627ea
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/fullscreen/fullscreen-controller.js b/src/fullscreen/fullscreen-controller.js
@@ -26,7 +26,7 @@ class FullscreenController {
   _isScreenLocked: boolean = false;
   _isScreenOrientationSupport: boolean =
     // $FlowFixMe
-    screen && screen.orientation && typeof screen.orientation.unlock === 'function' && typeof screen.orientation.lock === 'function';
+    !!screen && !!screen.orientation && typeof screen.orientation.unlock === 'function' && typeof screen.orientation.lock === 'function';
   _eventManager: EventManager;
   // Flag to overcome browsers which supports more than one fullscreenchange event
   _isFullscreenEventDispatched: boolean = false;
@@ -172,7 +172,8 @@ class FullscreenController {
       () => {
         this._isInFullscreen = true;
         const screenLockOrientionMode = Utils.Object.getPropertyPath(this._player, 'config.playback.screenLockOrientionMode');
-        const validOrientation = Object.values(ScreenOrientationType).includes(screenLockOrientionMode);
+        const validOrientation =
+          screenLockOrientionMode !== ScreenOrientationType.NONE && Object.values(ScreenOrientationType).includes(screenLockOrientionMode);
         if (this._isScreenOrientationSupport && validOrientation) {
           screen.orientation
             // $FlowFixMe

diff --git a/src/player-config.js b/src/player-config.js
@@ -1,3 +1,5 @@
+import {ScreenOrientationType} from './screen-orientation-type';
+
 const DefaultConfig = {
   log: {
     level: 'ERROR'
@@ -37,7 +39,7 @@ const DefaultConfig = {
       dash: false
     },
     inBrowserFullscreen: false,
-    screenLockOrientionMode: '',
+    screenLockOrientionMode: ScreenOrientationType.NONE,
     playAdsWithMSE: false,
     streamPriority: [
       {

diff --git a/src/screen-orientation-type.js b/src/screen-orientation-type.js
@@ -1,5 +1,6 @@
 // @flow
 const ScreenOrientationType: PKOrientationType = {
+  NONE: 'none',
   ANY: 'any',
   NATURAL: 'natural',
   LANDSCAPE: 'landscape',