Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7317): check if VTTCue and TextTrackCue are not undefined #137

Merged
merged 2 commits into from
Oct 19, 2017
Merged

fix(FEC-7317): check if VTTCue and TextTrackCue are not undefined #137

merged 2 commits into from
Oct 19, 2017

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Oct 19, 2017 •
edited
Loading

Description of the Changes

instanceof check on undefined method caused IE11 and Edge to fail on oncuechange event handler, make sure window.VTTCue exist before checking against instance of it.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from dan-ziv October 19, 2017 11:26
@yairans yairans self-assigned this Oct 19, 2017
@yairans yairans merged commit 604f7a6 into master Oct 19, 2017
@yairans yairans deleted the FEC-7317 branch October 19, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @dan-ziv