Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7317): check if VTTCue and TextTrackCue are not undefined #137

Merged
merged 2 commits into from
Oct 19, 2017
Merged

fix(FEC-7317): check if VTTCue and TextTrackCue are not undefined #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
311068b
fix(FEC-7317): check if VTTCue and TextTrackCue are not undefined
yairans Oct 19, 2017
505c713
Merge branch 'master' into FEC-7317
yairans Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/engines/html5/html5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,9 +770,9 @@ export default class Html5 extends FakeEventTarget implements IEngine {
textTrack.mode = 'hidden';
for (let cue of textTrack.activeCues) {
//Normalize cues to be of type of VTT model
if (cue instanceof window.VTTCue) {
if (window.VTTCue && cue instanceof window.VTTCue) {
activeCues.push(cue);
} else if (cue instanceof window.TextTrackCue) {
} else if (window.TextTrackCue && cue instanceof window.TextTrackCue) {
activeCues.push(new Cue(cue.startTime, cue.endTime, cue.text));
}
}
Expand Down