fix(FEC-10510): iOS14 - cannot exit from native PiP by the player's PiP button #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
changed the title
OrenMe
reviewed
Sep 29, 2020
| } else if (typeof this._el.webkitSetPresentationMode === 'function') { | ||
| this._el.webkitSetPresentationMode('inline'); | ||
| // Safari does not fire this event but Chrome does, normalizing the behaviour | ||
| setTimeout(() => this.dispatchEvent(new FakeEvent(Html5EventType.LEAVE_PICTURE_IN_PICTURE)), 0); |
There was a problem hiding this comment.
we don't need the event anymore?
There was a problem hiding this comment.
Actually, I don't see where this code was relevant, in all safari I've checked (mac, iPad with ios 11, 12, 13, and ios 14) this code was unreachable (means the if was applied not the else if).
After this change, I see this event fired natively.
Yuvalke
previously approved these changes
Oct 18, 2020
5 tasks
OrenMe
approved these changes
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
exitPictureInPicturewhen it's native PiP but usewebkitSetPresentationMode('inline')LEAVE_PICTURE_IN_PICTUREfiring. it's already fired natively.Solves FEC-10510
CheckLists