fix(FEC-10513): iOS14 - cannot enter to full screen from PiP #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
changed the title
Yuvalke
suggested changes
Oct 1, 2020
src/engines/html5/html5.js
Outdated
| // Second condition is because flow does not support this API yet | ||
| if (document.pictureInPictureEnabled && typeof this._el.requestPictureInPicture === 'function') { | ||
| if (typeof this._el.webkitSetPresentationMode === 'function') { | ||
| this._el.webkitSetPresentationMode('picture-in-picture'); |
There was a problem hiding this comment.
please move 'picture-in-picture' to const
There was a problem hiding this comment.
it's browser's string. we use it as is (like 'function', 'inline', 'playsinline' and many more)
src/engines/html5/html5.js
Outdated
| } else if (typeof this._el.webkitSetPresentationMode === 'function') { | ||
| this._el.webkitSetPresentationMode('picture-in-picture'); | ||
| // Safari does not fire this event but Chrome does, normalizing the behaviour | ||
| setTimeout(() => this.dispatchEvent(new FakeEvent(Html5EventType.ENTER_PICTURE_IN_PICTURE)), 0); |
There was a problem hiding this comment.
don't you miss this event on your change?
There was a problem hiding this comment.
no. it's not actually needed
There was a problem hiding this comment.
no. here I changed enterPictureInPicture. there I changed exitPictureInPicture.
Yuvalke
previously approved these changes
Oct 18, 2020
yairans
changed the title
OrenMe
previously approved these changes
Oct 18, 2020
| videoElement.webkitEnterFullScreen(); | ||
| if (this._player.isInPictureInPicture()) { | ||
| // iOS < 13 (iPad) has an issue to enter to full screen from PiP | ||
| setTimeout(() => videoElement.webkitEnterFullScreen(), 1000); |
There was a problem hiding this comment.
Let’s just move the 1000 magic number to const at the top, beside that LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
isFullscreen- was returntrueon PiPSolves FEC-10513
CheckLists