feat(FEC-10486): Lock orientation according to screenLockOrientionMode config when switching to full screen #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…screen Lock orientation to landscape when switching to full screen and new config disableFullScreenOrientation to disable it.
Yuvalke
changed the title
OrenMe
reviewed
Nov 2, 2020
There was a problem hiding this comment.
I think we should change the config to accepts the orientation as a config option that accepts any of the acceptable strings as described here: https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/lock
"any"
"natural"
"landscape"
"portrait"
"portrait-primary"
"portrait-secondary"
"landscape-primary"
"landscape-secondary"
if it is set then use the value on the request for lock()
RoyBregman
reviewed
Nov 23, 2020
OrenMe
reviewed
Nov 23, 2020
OrenMe
reviewed
Nov 23, 2020
OrenMe
reviewed
Nov 23, 2020
OrenMe
reviewed
Nov 23, 2020
RoyBregman
previously approved these changes
Nov 24, 2020
OrenMe
suggested changes
Nov 24, 2020
OrenMe
reviewed
Nov 24, 2020
OrenMe
reviewed
Nov 24, 2020
OrenMe
suggested changes
Nov 24, 2020
Co-authored-by: Oren Me <[email protected]>
OrenMe
reviewed
Nov 25, 2020
OrenMe
approved these changes
Nov 25, 2020
OrenMe
changed the title
Yuvalke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
add screenLockOrientionMode config to be able to lock the screen mode in fullscreen.
new enum with possible values for this config:
"none" "any" "natural" "landscape" "portrait" "portrait-primary" "portrait-secondary" "landscape-primary" "landscape-secondary"Solves FEC-10486
CheckLists