fix(FEC-10844): advanced caption settings custom caption is always marked even when choose sample #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rked even when choose sample Issue: condition of || doesn't work properly with 0 as current value and always take the second option. Solution: create the defaultValues as static getter to be able to use it on static methods and on first initilize of the properties. merge the setting and default value to make sure all set correctly. add relevant tests.
OrenMe
suggested changes
Dec 30, 2020
RoyBregman
reviewed
Dec 31, 2020
src/track/text-style.js
Outdated
Comment on lines
143
to
147
| let value = defaultValue; | ||
| if (typeof newValue !== 'undefined' && newValue !== null) { | ||
| value = newValue; | ||
| } | ||
| return value; |
There was a problem hiding this comment.
can be replace with a one liner:
return (typeof newValue !== 'undefined' && newValue !== null) ? newValue : defaultValue
But its a matter of taste...
There was a problem hiding this comment.
So unless you wanna change this to my suggestion then it is approved
RoyBregman
reviewed
Dec 31, 2020
RoyBregman
reviewed
Dec 31, 2020
RoyBregman
approved these changes
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: the condition of || doesn't work properly with 0 as the current value and always takes the default option.
Solution: create the default values as a static getter to be able to use it on static methods and on the first initialize of the properties.
merge the setting and default value to make sure all set correctly.
add relevant tests.
CheckLists