Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10844): advanced caption settings custom caption is always marked even when choose sample #525

Merged
merged 7 commits into from
Dec 31, 2020
Merged

fix(FEC-10844): advanced caption settings custom caption is always marked even when choose sample #525

merged 7 commits into from
Dec 31, 2020

Commits on Dec 30, 2020

  1. fix(FEC-10844): advanced caption settings custom caption is always ma… 

    …rked even when choose sample

Issue: condition of || doesn't work properly with 0 as current value and always take the second option.
Solution: create the defaultValues as static getter to be able to use it on static methods and on first initilize of the properties.
merge the setting and default value to make sure all set correctly.
add relevant tests.
    @Yuvalke
    Yuvalke committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    6cee556 View commit details
    Browse the repository at this point in the history

  2. Update src/track/text-style.js 

    Co-authored-by: Oren Me <[email protected]>
    @Yuvalke @OrenMe
    Yuvalke and OrenMe committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    aa99c7b View commit details
    Browse the repository at this point in the history

  3. fix PR

    @Yuvalke
    Yuvalke committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    ece8e45 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'FEC-10844' of https://github.com/kaltura/playkit-js into … 

    …FEC-10844
    @Yuvalke
    Yuvalke committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    f870241 View commit details
    Browse the repository at this point in the history

  5. Update text-style.js

    @Yuvalke
    Yuvalke committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    cf415c1 View commit details
    Browse the repository at this point in the history

  6. add more problematic value options to tests

    @Yuvalke
    Yuvalke committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    ce4cf29 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2020

  1. Update text-style.js

    @Yuvalke
    Yuvalke committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    930f40c View commit details
    Browse the repository at this point in the history