Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default text font family and expose ENUM #130

Merged
merged 8 commits into from
Oct 10, 2017
Merged

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Oct 8, 2017

Description of the Changes

add default text font-family to text style and expose the TextStyle on the player instance so ENUM is more accessible.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe closed this Oct 9, 2017
@OrenMe OrenMe reopened this Oct 9, 2017
*/
static FontFamily: {[string]: string} = {
"ARIAL": "Arial",
"ROBOTO": "Roboto",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't expose Roboto and other custom non-system fonts in the enum.
Maybe Hillel can assist with the font choice but I would go with:
'sans-serif' and 'serif'
other than that, the custom skin can define his own custom fonts and add it to the font options.

@OrenMe OrenMe merged commit 5384eb2 into master Oct 10, 2017
@OrenMe OrenMe deleted the captionDefaults branch October 10, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants