Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter empty video element text tracks #150

Merged
merged 1 commit into from
Oct 26, 2017
Merged

fix: filter empty video element text tracks #150

merged 1 commit into from
Oct 26, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Oct 26, 2017 •
edited
Loading

Description of the Changes

Filter text tracks without language or label.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Oct 26, 2017
@dan-ziv dan-ziv merged commit 58ada7c into master Oct 26, 2017
@dan-ziv dan-ziv deleted the filter-text-tracks branch October 26, 2017 10:34
yairans added a commit that referenced this pull request Oct 26, 2017
@yairans
Revert "fix: filter empty video element text tracks (#150)"
27f6dfb 
This reverts commit 58ada7c.
yairans added a commit that referenced this pull request Oct 29, 2017
@yairans
Revert "fix: filter empty video element text tracks (#150)" (#151)
99c671b 
This reverts commit 58ada7c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans yairans approved these changes

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-ziv @OrenMe @yairans