Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add buffered api #169

Merged
merged 1 commit into from
Dec 3, 2017
Merged

feat: add buffered api #169

merged 1 commit into from
Dec 3, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 30, 2017 •
edited
Loading

Description of the Changes

buffered implementation was empty.
buffered will serve us also in the UI to implement the buffered progress bar (now it's hard coded on 60%).

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Nov 30, 2017
@dan-ziv dan-ziv mentioned this pull request Nov 30, 2017
Merged
5 tasks
@dan-ziv dan-ziv merged commit d761b6c into master Dec 3, 2017
@dan-ziv dan-ziv deleted the buffered-api branch December 3, 2017 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe