Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-7564): trigger timeupdate in case of live when the playback is paused #191

Merged
merged 4 commits into from
Feb 12, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Feb 12, 2018

Description of the Changes

in live when the playback is paused the video element doesn't trigger timeupdate event,
this causes the ui (which listens to timeupdate to update the currentTime) to be out of sync.
so each durationchange if video is paused we trigger timeupdate.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans changed the title fix: trigger timeupdate in case of live when the playback is paused fix(FEC-7564): trigger timeupdate in case of live when the playback is paused Feb 12, 2018
@yairans yairans merged commit 68ba8bf into master Feb 12, 2018
@yairans yairans deleted the time-update-live branch February 12, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants