fix(FEC-10516): Fullscreen event dispatched twice from the player #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuvalke
suggested changes
Sep 30, 2020
| @@ -19,6 +19,8 @@ class FullscreenController { | |||
| _player: Player; | |||
| _isInBrowserFullscreen: boolean; | |||
| _eventManager: EventManager; | |||
| // Flag to overcome browsers which supports more than one fullscreenchange event | |||
| _isFullscreenEventDispatched: boolean = false; | |||
There was a problem hiding this comment.
Which browsers does it?
It was in the past and I removed it since shaka polyfill cause this issue.
There was a problem hiding this comment.
Has nothing to do with Shaka AFAIK.
Happens on Safari which supports fullscreenchange and webkitfullscreenchange
and on IE/Edge which supports fullscreenchange and msfullscreenchange.
There was a problem hiding this comment.
Shaka fixed this polyfill on their side
There was a problem hiding this comment.
these are double events we getting from registering them all.
We will open a task to register the correct events like screenfull library is doing.
OrenMe
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Add flag to overcome browsers which supports more than one fullscreenchange event.
CheckLists