Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10925): remove captions update delay #534

Merged
merged 2 commits into from
Jan 31, 2021
Merged

feat(FEC-10925): remove captions update delay #534

merged 2 commits into from
Jan 31, 2021

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Jan 19, 2021 •
edited
Loading

Description of the Changes

We used to rely on fullscreen event to change captions size and position. this event used to fire before screen dimensions were settled.
We now use a more precise resize observer manager and can remove the delay that causes a blinking effect.

Solves FEC-10925

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe requested a review from yairans January 19, 2021 08:19
@OrenMe OrenMe merged commit 8497153 into master Jan 31, 2021
@OrenMe OrenMe deleted the FEC-10925 branch January 31, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @yairans