fix(FEC-11606): Add TextTrack label to TIMED_METADATA event payload #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
approved these changes
Oct 4, 2021
semarche-kaltura
changed the title
OrenMe
reviewed
Oct 5, 2021
| @@ -1165,7 +1165,7 @@ export default class Html5 extends FakeEventTarget implements IEngine { | |||
| const listenToCueChange = track => { | |||
| track.mode = PKTextTrack.MODE.HIDDEN; | |||
| this._eventManager.listen(track, 'cuechange', () => { | |||
| this.dispatchEvent(new FakeEvent(CustomEventType.TIMED_METADATA, {cues: Array.from(track.activeCues)})); | |||
| this.dispatchEvent(new FakeEvent(CustomEventType.TIMED_METADATA, {cues: Array.from(track.activeCues), label: track.label})); | |||
There was a problem hiding this comment.
Label is the data source attribute of the text track but who said times metadata data source will always be a text track.
This is an example of leaking implementation detail.
I assume this was done for "easier" filtering but it leads to tightly coupling text track and the timed metadata event and needs to be removed.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
TIMED_METADATA event payload contains label to define which TextTrack dispatched event
CheckLists