fix(FEC-11697): 2 captions are selected in the menu #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2022
added 3 commits
February 10, 2022 16:03
yairans
reviewed
Feb 13, 2022
yairans
reviewed
Feb 13, 2022
added 2 commits
February 13, 2022 14:29
yairans
suggested changes
Feb 13, 2022
yairans
reviewed
Feb 14, 2022
added 2 commits
February 14, 2022 16:20
yairans
reviewed
Feb 14, 2022
yairans
reviewed
Feb 16, 2022
yairans
reviewed
Feb 16, 2022
yairans
reviewed
Feb 20, 2022
yairans
approved these changes
Feb 20, 2022
JonathanTGold
added a commit
to kaltura/playkit-js-hls
that referenced
this pull request
Mar 2, 2022
see kaltura/playkit-js#633 **in addition regardless of the original issue** add error handling on load() method. **issue:** the promise will remain 'pending' forever ... in case an manifest loading error Since the promise resolving returned from the load() rely on Hlsjs.Events.MANIFEST_LOADED event https://github.com/kaltura/playkit-js-hls/blob/master/src/hls-adapter.js#L140 to be resolved which is not fired in case of en error **fix:** call promise reject in case of fatal error and still pending promise solves: FEC-11697 and FEC-11893 related pr: kaltura/playkit-js-dash#182 kaltura/playkit-js#633
JonathanTGold
added a commit
to kaltura/playkit-js-dash
that referenced
this pull request
Sep 7, 2022
borhandarabi
pushed a commit
to TasvirChi/playchi-js-dash
that referenced
this pull request
May 14, 2024
see kaltura/playkit-js#633 solves: FEC-11697 and FEC-11893 related pr: kaltura/playkit-js-hls#161 kaltura/playkit-js#633
borhandarabi
pushed a commit
to TasvirChi/playchi-js-hls
that referenced
this pull request
May 14, 2024
see kaltura/playkit-js#633 **in addition regardless of the original issue** add error handling on load() method. **issue:** the promise will remain 'pending' forever ... in case an manifest loading error Since the promise resolving returned from the load() rely on Hlsjs.Events.MANIFEST_LOADED event https://github.com/kaltura/playkit-js-hls/blob/master/src/hls-adapter.js#L140 to be resolved which is not fired in case of en error **fix:** call promise reject in case of fatal error and still pending promise solves: FEC-11697 and FEC-11893 related pr: kaltura/playkit-js-dash#182 kaltura/playkit-js#633
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
issue: the create _addTextTrackOffOption method of the player creates duplicated indexes every time duplicated languages are detected (and warning created);
fix: right now the index property of TextTrack is used as a unique identifier but in the other hand we don't mange it as such (the index is created in different places), so , the index management all moved to one place under the TextTrack class
related pr:
kaltura/playkit-js-dash#182
kaltura/playkit-js-hls#161
solves: FEC-11697 & FEC-11893 & FEC-11973
CheckLists