feat(FEC-11979): add setCurrentTime middleware #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyBregman
previously approved these changes
Feb 23, 2022
There was a problem hiding this comment.
LGTM, I suggest @semarche-kaltura will use this PR locally and check if it works perfect for us before merging
SivanA-Kaltura
requested changes
Feb 23, 2022
| _setCurrentTime(to: number): void { | ||
| if (this._engine) { | ||
| if (Utils.Number.isNumber(to)) { | ||
| let boundedTo = to; |
There was a problem hiding this comment.
Suggested change
| let boundedTo = to; | |
| const boundedTo = to < 0 ? 0 : boundedTo; |
| if (boundedTo > safeDuration) { | ||
| boundedTo = safeDuration; | ||
| } | ||
| this._engine.currentTime = boundedTo; |
There was a problem hiding this comment.
Suggested change
| this._engine.currentTime = boundedTo; | |
| this._engine.currentTime = Math.min(boundedTo, safeDuration); |
Co-authored-by: Sivan Agranov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
add setCurrentTime middleware
add support for middleware params chaining
Solves FEC-11979
CheckLists