Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12596): Related plugin doesn't load because of an exception #667

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix(FEC-12596): Related plugin doesn't load because of an exception #667

merged 1 commit into from
Sep 28, 2022

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Sep 28, 2022 •
edited
Loading

Description of the Changes

Rename fake-event-target logger to not conflict with children.

Resolves FEC-12596.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura merged commit 6f799ad into master Sep 28, 2022
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-12596-rename-fake-event-target-logger branch September 28, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladna giladna giladna approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SivanA-Kaltura @giladna