Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12615): add configuration to toggle emsg listener #668

Merged
merged 3 commits into from
Oct 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,8 @@ var config = {
> ```js
> {
> forceBreakStall: boolean,
> lowLatencyMode: boolean
> lowLatencyMode: boolean,
> trackEmsgEvents: boolean
> }
> ```
>
Expand All @@ -1066,8 +1067,9 @@ var config = {
> ```js
> {
> forceBreakStall: false,
> lowLatencyMode: true // default for hls playback (optional)
> lowLatencyMode: false // default for dash & smart TV playback (optional)
> lowLatencyMode: true, // default for hls playback (optional)
> lowLatencyMode: false, // default for dash & smart TV playback (optional)
> trackEmsgEvents: true // default for dash (optional)
> }
> ```
>
Expand All @@ -1087,9 +1089,17 @@ var config = {
> >
> > ##### Type: `boolean`
> >
> > ##### Default: hls: `true`, dash and smart TV: `false` (in smart TV due to an issue in dash on samsung)
> > ##### Default: hls: `true`, dash and smart TV: `false` (in smart TV due to an issue in dash on samsung)
> >
> > ##### Description: Enable low latency streaming mode
> >
> > ##
> >
> > ### config.streaming.trackEmsgEvents (optional)
> >
> > ##### Default: dash: `true`
> >
> > ##### Description: Toggle emsg event listener on/off in dash adapter

##

Expand Down
3 changes: 2 additions & 1 deletion flow-typed/types/streaming-config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// @flow
declare type PKStreamingConfigObject = {
forceBreakStall: boolean,
lowLatencyMode: boolean
lowLatencyMode: boolean,
trackEmsgEvents: boolean
};