Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12648): Text style configuration is not working #669

Merged
merged 5 commits into from
Oct 20, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Oct 19, 2022

Description of the Changes

solves: FEC-12648

Findings:

1. by Default, the player uses its own text displayer and not the browser's native one
2. there are two level of text style (in PKTextConfigObject type):

textTrackDisplaySetting: PKTextTrackDisplaySettingObject,
textStyle: PKTextStyleObject,forceCenter: boolean,

3. by default both of them work
4. in case you use the browser native text tracks (useNativeTextTrack set to true) - only textStyle works
5. in case you use Shaka text displayer (useShakaTextTrackDisplay set to true) - none of them work

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold requested review from Yuvalke, SivanA-Kaltura and giladna and removed request for Yuvalke October 19, 2022 11:44
src/track/text-style.js Outdated Show resolved Hide resolved
JonathanTGold added 2 commits October 19, 2022 16:03
flow-typed/types/text-style.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants