Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gatsby-plugin-i18n-tags #83

Merged
merged 39 commits into from
May 3, 2019
Merged

adding gatsby-plugin-i18n-tags #83

merged 39 commits into from
May 3, 2019

Conversation

kalwalt
Copy link
Owner

@kalwalt kalwalt commented Apr 28, 2019

Basically i want to add tags support for different languages. I'm using the gatsby-plugin-i18n-tags.

@kalwalt
Copy link
Owner Author

kalwalt commented Apr 30, 2019

the issue with image as posted in angeloocana/gatsby-plugin-i18n#63 is solved upgrading the packages with Yarn: running yarn upgrade, though i have another issue with graphQL schema but i think i can solve it.

@kalwalt
Copy link
Owner Author

kalwalt commented May 1, 2019

Next step is to modify the Layout component. Basically it was failing because i was retriving the data with a wrong GraphQL query.

@kalwalt
Copy link
Owner Author

kalwalt commented May 1, 2019

due to the latest changes and re-changes the warning:

React-Hot-Loader: react-🔥-dom patch is not detected. React 16.6+ features may not work.

pop up again; as a note for the future i must remember this two references:

gatsbyjs/gatsby#11934 and the rreact-dom @hot-loader https://github.com/gaearon/react-hot-loader/tree/7089062eac273832102c074a368d5af27e23e0b0#react--dom

@kalwalt
Copy link
Owner Author

kalwalt commented May 1, 2019

production build fails and in develop i get lot of this kind of errors:

Error: A plugin tried to update a node field that it doesn't own:
  Node id: 39b35ac4-9bce-5166-87d4-328da09469d8
  Plugin: default-site-plugin
  name: slug
  value: /tags/index.it/

This error happened in the past but i don't remember how i solved... i will look into it in the next days...

@kalwalt
Copy link
Owner Author

kalwalt commented May 3, 2019

Now i had to improve the css styling and the retrieve list of the blog posts.

@kalwalt
Copy link
Owner Author

kalwalt commented May 3, 2019

In allTags page for the tag, in the footer langKey is always en, that is wrong because when in the italian page should be it... I'm investigating it. Not ready to be merged yet....

@kalwalt
Copy link
Owner Author

kalwalt commented May 3, 2019

Now i can merge it!

@kalwalt kalwalt merged commit bcd908c into dev May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code design enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant