Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab CI/CD Code Quality support #2024

Closed
wants to merge 3 commits into from

Conversation

jord1e
Copy link

@jord1e jord1e commented Oct 1, 2021

🚧 In Progress, do not merge 🚧

Description

Fixes #1990 (the proposal) and #1517 (original idea, in the simplest form).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-inspector/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@vercel
Copy link

vercel bot commented Oct 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/inspector-org/graphql-inspector/HkNBxLGDFyvhRVWYj21YHdWZr9EZ
✅ Preview: https://graphql-inspector-git-fork-jord1e-gitlab-support-inspector-org.vercel.app

@jord1e
Copy link
Author

jord1e commented Jan 12, 2023

See #1990

You can take this PR and work further with it.

@jord1e jord1e closed this Jan 12, 2023
@theguild-bot theguild-bot mentioned this pull request Apr 16, 2023
39 tasks
@theguild-bot theguild-bot mentioned this pull request Oct 26, 2023
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotations in GitLab (pull request proposal)
2 participants