Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new bob version #2419

Merged
merged 33 commits into from
Apr 10, 2023
Merged

Use new bob version #2419

merged 33 commits into from
Apr 10, 2023

Conversation

TuvalSimha
Copy link
Collaborator

Signed-off-by: Tuval [email protected]

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-inspector/...:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

Signed-off-by: Tuval <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2023

🦋 Changeset detected

Latest commit: dd773a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@graphql-inspector/introspect-command Patch
@graphql-inspector/commands Patch
@graphql-inspector/coverage-command Patch
@graphql-inspector/validate-command Patch
@graphql-inspector/similar-command Patch
@graphql-inspector/graphql-loader Patch
@graphql-inspector/loaders Patch
@graphql-inspector/audit-command Patch
@graphql-inspector/serve-command Patch
@graphql-inspector/github-loader Patch
@graphql-inspector/diff-command Patch
@graphql-inspector/docs-command Patch
@graphql-inspector/code-loader Patch
@graphql-inspector/json-loader Patch
@graphql-inspector/git-loader Patch
@graphql-inspector/url-loader Patch
@graphql-inspector/action Patch
@graphql-inspector/config Patch
@graphql-inspector/github Patch
@graphql-inspector/logger Patch
@graphql-inspector/core Patch
@graphql-inspector/cli Patch
@graphql-inspector/ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Tuval <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2023

💻 Website Preview

The latest changes are available as preview in: https://59a4bb60.graphql-inspector.pages.dev

@TuvalSimha TuvalSimha changed the title typescript Use new bob version Mar 26, 2023
TuvalSimha and others added 23 commits March 26, 2023 17:49
Signed-off-by: Tuval <[email protected]>
Signed-off-by: Tuval <[email protected]>
Signed-off-by: Tuval <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
    "check": false
  },

Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
?
Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
?
Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
?
Signed-off-by: TuvalSimha <[email protected]>
?
Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
TuvalSimha and others added 5 commits April 4, 2023 22:49
Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
Signed-off-by: TuvalSimha <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-inspector/action 3.4.9-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/ci 3.4.6-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/cli 3.4.10-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/audit-command 3.4.8-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/commands 3.4.5-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/coverage-command 4.0.4-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/diff-command 3.4.8-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/docs-command 3.4.6-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/introspect-command 3.4.8-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/serve-command 3.4.6-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/similar-command 3.4.8-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/validate-command 3.4.8-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/config 3.4.4-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/core 4.0.3-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/github 3.4.9-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/code-loader 3.4.3-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/git-loader 3.4.3-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/github-loader 3.4.3-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/graphql-loader 3.4.3-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/json-loader 3.4.3-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/loaders 3.4.5-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/url-loader 3.4.3-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎
@graphql-inspector/logger 3.4.4-alpha-20230410135720-dd773a38 npm ↗︎ unpkg ↗︎

Signed-off-by: TuvalSimha <[email protected]>
@TuvalSimha
Copy link
Collaborator Author

The CLI alpha version: 3.4.10-alpha-20230410135720-dd773a38 was tested:

  1. Coverage
info Schema coverage based on documents:

type Post {
  id x 1
  title x 1
  createdAt x 0
  modifiedAt x 0
}

type Query {
  post x 1
  posts x 0
}

2.Validate

Detected 1 invalid document:

error
in /Users/tuvalsimha/Desktop/untitled folder/example/documents/post.graphql:


 - Cannot query field createdAtSomePoint on type Post.
  1. Serve
    success GraphQL API: http://localhost:4000

  2. Introspect
    success Saved to /Users/tuvalsimha/Desktop/untitled folder/graphql.schema.json

  3. Diff

 Detected the following changes (7) between schemas:

✖  Field modifiedAt was removed from object type Post
✖  Field posts was removed from object type Query
⚠  Field Post.title is no longer deprecated
✔  Field Post.createdAt changed type from String to String!
✔  Field Post.id changed type from ID to ID!
✔  Deprecation reason was removed from field Post.title
✔  Field Post.title changed type from String to String!
error Detected 2 breaking changes
  1. Coverage
info Schema coverage based on documents:

type Post {
  id x 1
  title x 1
  createdAt x 0
  author x 0
}

type User {
  id x 0
  name x 0
}

type Query {
  post x 1
}
  1. help - ✅
  2. docs - ✅

@TuvalSimha TuvalSimha merged commit 34f84e8 into master Apr 10, 2023
@TuvalSimha TuvalSimha deleted the bob_update branch April 10, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants