Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coverage): Stats for coverage command #2452

Merged
merged 9 commits into from
Apr 24, 2023
Merged

feat(coverage): Stats for coverage command #2452

merged 9 commits into from
Apr 24, 2023

Conversation

TuvalSimha
Copy link
Collaborator

@TuvalSimha TuvalSimha commented Apr 18, 2023 •
edited
Loading

Signed-off-by: TuvalSimha [email protected]

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-inspector/...:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e7d6d15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@graphql-inspector/coverage-command Patch
@graphql-inspector/logger Patch
@graphql-inspector/core Patch
@graphql-inspector/cli Patch
@graphql-inspector/ci Patch
@graphql-inspector/audit-command Patch
@graphql-inspector/diff-command Patch
@graphql-inspector/introspect-command Patch
@graphql-inspector/serve-command Patch
@graphql-inspector/similar-command Patch
@graphql-inspector/validate-command Patch
@graphql-inspector/action Patch
@graphql-inspector/github Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-inspector/action 3.4.15-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/ci 3.4.10-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/cli 3.4.16-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/audit-command 3.4.12-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/coverage-command 4.0.8-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/diff-command 3.4.12-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/introspect-command 3.4.12-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/serve-command 3.4.8-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/similar-command 3.4.12-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/validate-command 3.5.1-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/core 4.2.1-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/github 3.4.13-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎
@graphql-inspector/logger 3.4.6-alpha-20230423132223-e7d6d155 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023 •
edited
Loading

💻 Website Preview

The latest changes are available as preview in: https://de24956e.graphql-inspector.pages.dev

@TuvalSimha
feat: Add new stats to coverage
6d250a7 
Signed-off-by: TuvalSimha <[email protected]>
@TuvalSimha
fix stats
fa61689 
Signed-off-by: TuvalSimha <[email protected]>
@TuvalSimha
Fix stats + docs + test
c20ca9e 
Signed-off-by: TuvalSimha <[email protected]>
@TuvalSimha TuvalSimha changed the title feat: Add new stats to coverage feat(coverage): Stats for coverage command Apr 20, 2023
@TuvalSimha TuvalSimha marked this pull request as ready for review April 20, 2023 11:36
@TuvalSimha
lint
5e6bea3 
Signed-off-by: TuvalSimha <[email protected]>
@TuvalSimha
prettier
e91d180 
Signed-off-by: TuvalSimha <[email protected]>
dotansimha
dotansimha reviewed Apr 23, 2023
View reviewed changes
Copy link
Collaborator

@dotansimha dotansimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add changeset file

@TuvalSimha
remove unions
cae3939 
Signed-off-by: TuvalSimha <[email protected]>
@TuvalSimha
prettier
d101128 
Signed-off-by: TuvalSimha <[email protected]>
@TuvalSimha
new assets
1821c86 
Signed-off-by: TuvalSimha <[email protected]>
@TuvalSimha
changeset
e7d6d15 
Signed-off-by: TuvalSimha <[email protected]>
@TuvalSimha TuvalSimha merged commit 1b1b954 into master Apr 24, 2023
@TuvalSimha TuvalSimha deleted the coverage-stats branch April 24, 2023 09:11
This was referenced Apr 24, 2023
Merged
Open
@theguild-bot theguild-bot mentioned this pull request Apr 27, 2023
Closed
39 tasks
@theguild-bot theguild-bot mentioned this pull request Oct 26, 2023
Open
38 tasks
This was referenced May 7, 2024
Closed
Closed
This was referenced May 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilkisiela kamilkisiela kamilkisiela approved these changes

@dotansimha dotansimha Awaiting requested review from dotansimha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TuvalSimha @dotansimha @kamilkisiela