Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(odin-html) - SVG Turkish Translation #742

Merged
merged 4 commits into from
May 23, 2024
Merged

docs(odin-html) - SVG Turkish Translation #742

merged 4 commits into from
May 23, 2024

Conversation

Doguhannilt
Copy link
Contributor

@Doguhannilt Doguhannilt commented Jan 10, 2024 •
edited
Loading

Description

Turkish translation of SVG's readme file

Checklist

  • [x ] discord username: doguhan_i
  • Closes #
  • PR must be created for an issue from issues under "In progress" column from our project board.
  • [ x] A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules, and should include the app/package/service name in the title. For example, a title like "docs(@kampus-apps/pano): Add README.md" can be used.
  • [ x] Related file selection: Only relevant files should be touched and no other files should be affected.
  • I ran npx turbo run at the root of the repository, and build was successful.
  • I installed the npm packages using npm install --save-exact <package> so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.

How were these changes tested?

Please describe the tests you did to test the changes you made. Please also specify your test configuration.

@Doguhannilt Doguhannilt requested a review from a team as a code owner January 10, 2024 17:31
@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024

@Doguhannilt is attempting to deploy a commit to the kamp-us Team on Vercel.

A member of the Team first needs to authorize it.

@huseyingulec huseyingulec added the content/odin issues related to odin project label Jan 10, 2024
huseyingulec
huseyingulec reviewed May 23, 2024
View reviewed changes
content/odin/intermediate_html_css/intermediate_html_concepts/svgs.md Outdated

There are two main approaches when deciding how to actually place the SVG in your document: linked, and inline.
SVG'yi belgenize nasıl yerleştireceğinizi kararlaştırırken iki temel yaklaşım vardır: bağlantılı ve iç içe (inline).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SVG'yi belgenize nasıl yerleştireceğinizi kararlaştırırken iki temel yaklaşım vardır: bağlantılı ve iç içe (inline).
SVG'yi belgenize nasıl yerleştireceğinizi kararlaştırırken iki temel yaklaşım vardır: bağlantılı ve iç içe(inline).

huseyingulec
huseyingulec approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@huseyingulec huseyingulec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the effort, good job.

@huseyingulec huseyingulec merged commit c182bbd into kamp-us:dev May 23, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyingulec huseyingulec huseyingulec approved these changes

@puskuruk puskuruk Awaiting requested review from puskuruk puskuruk is a code owner automatically assigned from kamp-us/kampus-devs

Assignees
No one assigned
Labels
content/odin issues related to odin project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doguhannilt @huseyingulec @cansirin